syscall: build without AT_SYMLINK_NOFOLLOW#1026
Merged
tridge merged 3 commits intoJul 20, 2026
Merged
Conversation
Member
Author
|
@tridge Should certainly be in 3.5 |
tridge
force-pushed
the
fix/no-at-symlink-nofollow
branch
from
July 19, 2026 22:40
905e349 to
abbd51b
Compare
Member
|
@steadytao I don't think this will fix all the issues with old macos. I've dug out an old mac-mini I have here and I'm working on getting a 10.6 based build going on it. |
tridge
approved these changes
Jul 20, 2026
tridge
left a comment
tridge
left a comment
Member
There was a problem hiding this comment.
turns out it does build with 10.6, merging for 3.5.0, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the upstream portion of #1025.
do_lstat_at()selected itsfstatat()implementation whenever symlink support was enabled. Older systems such as macOS 10.6 support symlinks but do not defineAT_FDCWDorAT_SYMLINK_NOFOLLOWso the unconditional reference toAT_SYMLINK_NOFOLLOWpreventedsyscall.cfrom compiling. This falls back todo_lstat()unless bothAT_FDCWDandAT_SYMLINK_NOFOLLOWare available. The same availability check is applied todo_lchown_at()because itsfchownat()implementation also requiresAT_SYMLINK_NOFOLLOW.